axelarnetwork / axelar-gmp-sdk-solidity

Solidity libraries and utilities provided by Axelar.
27 stars 32 forks source link

feature: error handling #126

Closed luislucena16 closed 7 months ago

luislucena16 commented 9 months ago

I add this error handling proposal, I find it cleaner and tidier to work with and also you leave the interface for the specific use i.e. without the errors there, I made sure it compiled!

re1ro commented 9 months ago

Hi @luislucena16! Thank you for the contribution! Usually splitting interfaces done is app level project and not at the library level, so the lib imports are simple. I know it's a preference thing, but are trying to keep it simple as the amount of utils and interfaces keeps growing.

Since the interface itself is tiny and not expected to change you could just have it defined in your project instead of importing.

luislucena16 commented 9 months ago

hey @re1ro yes, as you said, it is also considered a matter of preference! :) and of course, if the project grows, it is beneficial

luislucena16 commented 9 months ago

I was thinking about adding more documentation for contributors in the readme, when I was going to do it I didn't see any about it.. what do you think?

milapsheth commented 7 months ago

Yeah, we prefer to keep it this way for simplicity

milapsheth commented 7 months ago

I was thinking about adding more documentation for contributors in the readme, when I was going to do it I didn't see any about it.. what do you think?

Sure, additional documentation would be helpful, especially around usage of some our contracts/utils