axelarnetwork / axelar-gmp-sdk-solidity

Solidity libraries and utilities provided by Axelar.
27 stars 32 forks source link

feat(ValuedExpress): allocating value for token flows #155

Closed re1ro closed 2 weeks ago

re1ro commented 7 months ago
codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.68%. Comparing base (be86ab9) to head (53f46ee).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #155 +/- ## ======================================= Coverage 98.68% 98.68% ======================================= Files 48 48 Lines 759 759 Branches 158 158 ======================================= Hits 749 749 Misses 1 1 Partials 9 9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

re1ro commented 7 months ago

@Foivos yeah sorry, the only real change there is to allow to pass more value than estimated. To pay gas for consequent GMP calls etc

if (msg.value < value) revert InsufficientValue();