feat: create2 deployer - Githubissues

axelarnetwork / axelar-gmp-sdk-solidity

Solidity libraries and utilities provided by Axelar.

27 stars 32 forks source link

feat: create2 deployer #67

Closed re1ro closed 1 year ago

re1ro commented 1 year ago

[x] Create2Deployer: refactoring ConstAddressDeployer to follow the naming standards
[x] DeployCreate2 and DeployCreate3: refactoring library into a contract
[x] solidity: updating compiler to 0.8.19
[x] Create2Deployer: add separate test file.
[x] ConstAddressDeployer: add tests for deploying with native value
[x] Create3Deployer: fix bytecode checks when finalize the contracts

https://axelarnetwork.atlassian.net/browse/AXE-1300

deanamiel commented 1 year ago

When adding unit tests I found an issue with native transfer during deployment. The create2Deployer was sending the native value to the wrong address because it was calculating the deployment address with the deployment salt not the original salt meant to be passed to the deployedAddress function. I tweaked the contract a bit so it works now, let me know your thoughts @re1ro @milapsheth