axelarnetwork / axelarjs

Axelar Network foundations for Javascript/Typescript application development
Apache License 2.0
10 stars 8 forks source link

fix: search tokens loading times #418

Closed SGiaccobasso closed 2 months ago

SGiaccobasso commented 2 months ago

Description

Fix long loading times when searching for an address.

⛑️ What was done:

Set retry: false for TRPC query to get ERC20 token info. The query was being executed three times and each of these took a long time to complete, with one call being enough to get the same result.

Make the RPC calls to all chains concurrent for a much faster response.

Type of change

πŸ§ͺ How to test:

Search for tokens, especially tokens that do not exist, and the error should come much earlier than in production.

πŸ—’οΈ Notes:

βš–οΈ New vs Prod:

https://github.com/user-attachments/assets/953e9b39-e4d9-4cb9-ad0a-7b93d9f16407

The production app can take up to 35-45x longer to complete the search than the new version.

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
axelar-maestro βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Aug 15, 2024 8:45pm
axelar-registry βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Aug 15, 2024 8:45pm
axelar-ui βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Aug 15, 2024 8:45pm
changeset-bot[bot] commented 2 months ago

πŸ¦‹ Changeset detected

Latest commit: 5df0fad312f95a95cfa264c5a9f26cb972dfc186

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----------------- | ----- | | @axelarjs/maestro | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR