axelarnetwork / support

Your source for support with the Axelar Network
3 stars 1 forks source link

`deployTokenManager` stopped working? #90

Closed tab00 closed 3 months ago

tab00 commented 4 months ago

deployTokenManager seems to have stopped working. I tried it on some testnets but execution is always reverted.

Have there been changes made recently related to token managers that have caused this?

benjamin852 commented 4 months ago

Hey, what are you passing into the deployTokenManager() and on which chain are you calling this?

tab00 commented 4 months ago

what are you passing into the deployTokenManager()

salt: 0x437573746f6d546f6b656e203100000000000000000000000000000000000000 wallet.address: 0xEB2e452fC167b5bb948c6FC2c9215ce7F4064692 tokenAddress: 0xf563e3E4186114C6887f14d4E11dcE1D6d5E1E64 TOKENMANAGERTYPE_MINT_BURN_FROM: 1

I followed the example at https://github.com/axelarnetwork/axelar-examples/blob/f2eac9a7f5aaf4d9a72b9bf86e5bbc5fb5969307/examples/evm/its-custom-token/index.js#L37-L39

The token contract is exactly the same as https://github.com/axelarnetwork/axelar-examples/blob/main/examples/evm/its-custom-token/CustomToken.sol.

Here's the relevant part of the script (using the latest versions of hardhat and ethers):

  const params = ethers.AbiCoder.defaultAbiCoder().encode(['bytes', 'address'], [wallet.address, tokenAddress])

  const its = await ethers.getContractAt(`InterchainTokenService`, `0xB5FB4BE02232B1bBA4dC8f81dc24C26980dE9e3C`)
  let txResponse = await its.deployTokenManager(
    salt,
    ``, // destinationChain
    TOKENMANAGERTYPE_MINT_BURN_FROM,
    params,
    0 // gasValue
  )
  const txReceipt = await txResponse.wait()

on which chain are you calling this

BNB chain testnet

Here's the error output:

ProviderError: execution reverted: 
    at HttpProvider.request (C:\Users\tab00\Documents\Projects\axelar-its-test\node_modules\hardhat\src\internal\core\providers\http.ts:90:21)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at HardhatEthersProvider.estimateGas (C:\Users\tab00\Documents\Projects\axelar-its-test\node_modules\@nomicfoundation\hardhat-ethers\src\internal\hardhat-ethers-provider.ts:237:27)
    at C:\Users\tab00\Documents\Projects\axelar-its-test\node_modules\@nomicfoundation\hardhat-ethers\src\signers.ts:235:35
    at async Promise.all (index 0)
    at HardhatEthersSigner._sendUncheckedTransaction (C:\Users\tab00\Documents\Projects\axelar-its-test\node_modules\@nomicfoundation\hardhat-ethers\src\signers.ts:256:7)
    at HardhatEthersSigner.sendTransaction (C:\Users\tab00\Documents\Projects\axelar-its-test\node_modules\@nomicfoundation\hardhat-ethers\src\signers.ts:125:18)
    at send (C:\Users\tab00\Documents\Projects\axelar-its-test\node_modules\ethers\src.ts\contract\contract.ts:313:20)
    at Proxy.deployTokenManager (C:\Users\tab00\Documents\Projects\axelar-its-test\node_modules\ethers\src.ts\contract\contract.ts:352:16)
    at main (C:\Users\tab00\Documents\Projects\axelar-its-test\scripts\deploy-CustomTokenTokenManager.js:47:20)
bilgin-kocak commented 4 months ago

I have same issues. When I run deployTokenManager method I get https://links.ethers.org/v5-errors-CALL_EXCEPTION call exception error.

My paramaters were salt: 0x7e04743f6317f49cecfc43f1298f238c58cf505de539a9658149dafa9d9454ac destinationChain: "" tokenManagerType: 0 params: 0x0000000000000000000000000000000000000000000000000000000000000040000000000000000000000000c708443711b332699c83ad32cbcb6eab9d7fb3cd000000000000000000000000000000000000000000000000000000000000001448d185bc646534597e25199dd4d73692ebd98bac000000000000000000000000 gasValue: 0

Yesterday you upgrade the Interchain Token Service contract. I think you changed something inside deployTokenManager function. In the old Interchain Token Service contract, this function works properly. If I use these parameters for below old implemtation of Interchain Token Service contract the function deployTokenManager works properly

https://testnet.bscscan.com/address/0x30defb998d7fddc75ffb8d002fc15bbb75115758#writeContract

benjamin852 commented 4 months ago

I see, thanks for flagging this will look internally to see what the issue is here.

bilgin-kocak commented 4 months ago

Understanding the complexities involved in resolving such issues, I nevertheless kindly request your assistance in expediting a solution. Our client is eagerly anticipating the launch of the bridge application, and we are keen to meet their expectations within the given timeframe. If possible, could you share any updates on the resolution process, or verify the new contract in an explorer? This information could allow us to adjust our function parameters accordingly and proceed with deploying the token manager contract as planned.

tab00 commented 4 months ago

Was the new version fully tested before it was deployed in testnet?

It's extremely important to make sure that new versions are thoroughly tested and are fully working in your internal environment before deploying to public networks (including testnets).

benjamin852 commented 4 months ago

Thanks guys appreciate the feedback. I am still looking into this may take a week or two here, apologies, will let you know when I have any updates. Thanks

milapsheth commented 4 months ago

Hey guys, thanks for the patience and apologies for the disruption. We're making some improvements to the custom token manager flow, which required disabling token manager deployments temporarily. We're hoping to have it live soon and share more updates with you later next week.

milapsheth commented 4 months ago

The updated version is live on testnet/mainnet. Please see release notes here for changes to custom token deployment. Axelar docs will be updated soon as well. Let us know if you have any questions!

Olanetsoft commented 3 months ago

@bilgin-kocak @tab00 The docs is now updated. You can refer to this guide at https://docs.axelar.dev/dev/send-tokens/interchain-tokens/developer-guides/link-custom-tokens-deployed-across-multiple-chains-into-interchain-tokens. I will now close this issue. If you have any further questions, feel free to create a new issue, and we will be happy to assist you. Thank you!