Rename unwrap - Githubissues

axelarnetwork / tofn

A threshold cryptography library in Rust

Apache License 2.0

112 stars 23 forks source link

Rename unwrap #124

Closed milapsheth closed 3 years ago

milapsheth commented 3 years ago

Added AsRef for k256_serde wrappers to expose the k256 structs
Switched from unwrap() to as_ref()
Removed various potential panics
Switched from assert! to debug_assert!
Fixes #122
Fixes #121

ggutoski commented 3 years ago

https://github.com/axelarnetwork/tofn/pull/124#discussion_r686943202

Asserts are usually used as simple sanity checks for catching bugs during development rather than production so we don't want to compile them in release.

I guess. Maybe we should keep the debug_asserts. It would definitely be helpful in catching bugs eg here: https://github.com/axelarnetwork/tofn/pull/124#discussion_r686436337