axelarnetwork / tofn

A threshold cryptography library in Rust
Apache License 2.0
110 stars 23 forks source link

Restrict visibility of secret key share struct fields #152

Closed milapsheth closed 3 years ago

milapsheth commented 3 years ago

tofn structs like SecretKeyShare, GroupPublicInfo etc. visible in the API shouldn't expose their fields. The user only needs to be able to access the encoded public key, group info, and private recovery info. This can be allowed by keeping the corresponding the functions (pubkey_bytes etc.) public while keeping the fields private. tofnd will follow this approach starting in axelarnetwork/tofnd#160.

ggutoski commented 3 years ago

looks like this is now done