fix: send a dlog proof for h1 wrt h2

axelarnetwork / tofn

A threshold cryptography library in Rust

Apache License 2.0

107 stars 22 forks source link

fix: send a dlog proof for h1 wrt h2 #180

Closed milapsheth closed 2 years ago

milapsheth commented 2 years ago

Prove that the order of h1 and h2 are equal for the Zksetup. The previous proof only proved that h2 is in the subgroup <h1>. This bug was reported in this blog post for another implementation.
Update the max message sizes to accommodate the new proof.

milapsheth commented 2 years ago

There are 1 or 2 dangling comments but I might not be available before we need to merge, so I'll just approve and leave it to you to merge at your discretion. Worst case you can merge as-is and we can open new issues for any comments that demand more work.

Sure, I'll merge this, and let's discuss if we can improve the design more next week.