search

axelerant / drupal-quality-checker

Pre-commit code quality checker for Drupal based projects.
https://packagist.org/packages/axelerant/drupal-quality-checker
12 stars 9 forks source link

Exclude "\Drupal\Core\Site\Settings class of PHPMD StaticAccess rule #13

Closed sbrindle closed 3 years ago

sbrindle commented 3 years ago

Hello,

It is not possible to instantiate or use dependency injection to retrieve a site settings. So it is a good idea to add an exclusion for this class in the phpmd.xml.dist file

hussainweb commented 3 years ago

I agree. I will make this change soon unless you want to submit a PR first. :)

sbrindle commented 3 years ago

DONE :)

hussainweb commented 3 years ago

Thanks! I merged the PR.