search

axelerant / drupal-quality-checker

Pre-commit code quality checker for Drupal based projects.
https://packagist.org/packages/axelerant/drupal-quality-checker
12 stars 9 forks source link

Allow grumphp-shim to 2.x version. #27

Closed rajeshreeputra closed 10 months ago

rajeshreeputra commented 11 months ago

Fixes #25

hussainweb commented 11 months ago

Thanks, @rajeshreeputra. Is there any reason we should keep support for v1 of the shim? I don't think it has dependencies and so chances of conflicts with other packages is unlikely.

rajeshreeputra commented 11 months ago

Thanks, @rajeshreeputra. Is there any reason we should keep support for v1 of the shim? I don't think it has dependencies and so chances of conflicts with other packages is unlikely.

Agree Updated to use 2.x version. Thank you!!

rajeshreeputra commented 10 months ago

@hussainweb when can we expect a release.

hussainweb commented 10 months ago

@rajeshreeputra, since this is going to be a breaking release, I will release a new major version. For that, I wanted to change a few more things. Can I get your thoughts on #12 and #21? I also created #29 for a generic discussion.

rajeshreeputra commented 10 months ago

@rajeshreeputra, since this is going to be a breaking release, I will release a new major version. For that, I wanted to change a few more things. Can I get your thoughts on #12 and #21? I also created #29 for a generic discussion.

I believe a major version isn't necessary in this case; version 1.4.0 should suffice for this. We can proceed with maintenance on the 1.3.x version of phpro/grumphp-shim, addressing any issues that may arise in the 1.x version of phpro/grumphp-shim and resolving them accordingly.

hussainweb commented 10 months ago

Since we are moving to a new major version of a major dependency (GrumPHP), it is a good idea to make a new major release. I don't know what's changed between GrumPHP 1 and 2 but if there are significant changes, then users have to consciously choose to update.