axelerant / testimonials-widget

Easily add social proofing to your website with Testimonials Widget. List or slide reviews via functions, shortcodes, or widgets.
http://wordpress.org/plugins/testimonials-widget/
GNU General Public License v2.0
10 stars 7 forks source link

Theme functions not recognizing parameters #83

Closed michael-cannon closed 10 years ago

michael-cannon commented 10 years ago

both are showing the controls, and the ratings.

echo do_shortcode('[testimonials_slider show_controls=false show_ratings=false require_excerpt=true]');

$args = array( 
'show_controls' => false, 
'show_ratings' => false, 
);

echo testimonials_slider( $args );

But both are showing the controls, and the ratings.


https://aihrus.zendesk.com/agent/#/tickets/1862

michael-cannon commented 10 years ago

In research, this is a precedence issue. The add_filter( 'testimonials_widget_defaults', 'my_testimonials_widget_defaults' ); isn't being known before $defaults = apply_filters( 'testimonials_widget_defaults', $options ); is called.

Could be child-theme related. When my_testimonials_widget_defaults is in parent theme functions.php, filters work as expected. If my_testimonials_widget_defaults is in child theme functions.php, then it doesn't work as expected.

Ah… I had my my_testimonials_widget_defaults code wrapped in a if (false) so it wouldn't load for some other testing. This isn't a problem…

Checking with client.

michael-cannon commented 10 years ago

could not replicate