search

axeloz / filesharing

Self-hosted files sharing application, easy to setup, easy to use
https://filesharing.webinno.fr
GNU General Public License v3.0
230 stars 35 forks source link

[Feature Request] S3 Compatibility #59

Open sanskar-mk2 opened 9 months ago

sanskar-mk2 commented 9 months ago

Many cloud filesystem are s3 compatible, if we can do it, then we can have more ways to store file. I am working on it. Do you have suggestions?

axeloz commented 9 months ago

Hi @sanskar-mk2, you want to add the S3 support for Filesharing? Is that right?

sanskar-mk2 commented 9 months ago

Yes, I have a working S3 compatible (I am using Digital Ocean Spaces) version of the app. Are you working on any such plans right now? If not, I will be happy to PR it.

Additionally I have also made some quality of life updates to it.

axeloz commented 9 months ago

No, I had no plan on implementing S3 but with Flysystem on Laravel, it's pretty straightforward. Question is: is there a need for this?

sanskar-mk2 commented 9 months ago

Yes, there is need for it, since the filesystem is hardcoded in the controllers. And to create a zip file, you cannot write directly to S3. Some little changes are needed.

axeloz commented 9 months ago

I was talking about the functional need, a user request. But if you think some users may need to change the disk driver, then you are right: some improvements are required.

sanskar-mk2 commented 9 months ago

Yes, people use different disk driver. I need it so I can buy compute and storage separately.