Open tan-tan-kanarek opened 6 years ago
Hi, maybe we are too busy right now, but no worries, it is the part of the open source biz :) However, I need to close the PR soon because I am unable to understand the committed feature without your explaination and an example. Do not worry about lint issues, I can fix those, they are a minor thing.
Sorry @axelpale, I moved to a different project and forgot about it. I used it here: https://github.com/kaltura/api-gw/blob/d38d65eb8ea6da82cbd115683206ebbcddcbe4f1/lib/enrichers/xml-reducer.js
The tests that required this fix are here: https://github.com/kaltura/api-gw/blob/d38d65eb8ea6da82cbd115683206ebbcddcbe4f1/test/xml-reducer.test.js
Note to all the xPaths that include @
, they all refer to XML attribute and not to XML element (e.g. lines 15 and 97).
T.
Hi Tan, thanks for the PR! Great!
Before I am able to merge, may I ask you to do the following:
Fix lint issues, listed below from Travis build log:
71:7 error Expected space(s) after "if" keyword-spacing 75:1 error Trailing spaces not allowed no-trailing-spaces
By the way, if you are applying the
filterxml
module in a public project, I am happy to add a link to your project into README.md. It is always nice to know what people are building with tools we create :)