Open RRaideRR opened 3 months ago
same issue
Those files got moved to another folder internally on RN 0.74. Here's patch with the fix:
Those files got moved to another folder internally on RN 0.74. Here's patch with the fix:
react-native-animateable-text+0.12.0.patch
diff --git a/node_modules/react-native-animateable-text/android/src/main/java/com/reactnativereanimatedtext/CustomLineHeightSpan.java b/node_modules/react-native-animateable-text/android/src/main/java/com/reactnativereanimatedtext/CustomLineHeightSpan.java index 2319176..d9f0be5 100644 --- a/node_modules/react-native-animateable-text/android/src/main/java/com/reactnativereanimatedtext/CustomLineHeightSpan.java +++ b/node_modules/react-native-animateable-text/android/src/main/java/com/reactnativereanimatedtext/CustomLineHeightSpan.java @@ -10,7 +10,7 @@ package com.reactnativereanimatedtext; import android.graphics.Paint; import android.text.style.LineHeightSpan; -import com.facebook.react.views.text.ReactSpan; +import com.facebook.react.views.text.internal.span.ReactSpan; /** * We use a custom {@link LineHeightSpan}, because `lineSpacingExtra` is broken. Details here: diff --git a/node_modules/react-native-animateable-text/android/src/main/java/com/reactnativereanimatedtext/JBBaseTextShadowNode.java b/node_modules/react-native-animateable-text/android/src/main/java/com/reactnativereanimatedtext/JBBaseTextShadowNode.java index 063e7dd..e12b9de 100644 --- a/node_modules/react-native-animateable-text/android/src/main/java/com/reactnativereanimatedtext/JBBaseTextShadowNode.java +++ b/node_modules/react-native-animateable-text/android/src/main/java/com/reactnativereanimatedtext/JBBaseTextShadowNode.java @@ -16,39 +16,36 @@ import android.text.Spannable; import android.text.SpannableStringBuilder; import android.text.TextUtils; import android.view.Gravity; + import androidx.annotation.Nullable; + import com.facebook.infer.annotation.Assertions; import com.facebook.react.bridge.JSApplicationIllegalArgumentException; import com.facebook.react.bridge.ReadableArray; import com.facebook.react.bridge.ReadableMap; -import com.facebook.react.uimanager.IllegalViewOperationException; import com.facebook.react.uimanager.LayoutShadowNode; import com.facebook.react.uimanager.NativeViewHierarchyOptimizer; import com.facebook.react.uimanager.PixelUtil; import com.facebook.react.uimanager.ReactShadowNode; import com.facebook.react.uimanager.ViewProps; import com.facebook.react.uimanager.annotations.ReactProp; -import com.facebook.react.views.text.CustomLetterSpacingSpan; -import com.facebook.react.views.text.CustomStyleSpan; -import com.facebook.react.views.text.ReactAbsoluteSizeSpan; -import com.facebook.react.views.text.ReactBackgroundColorSpan; -import com.facebook.react.views.text.ReactForegroundColorSpan; -import com.facebook.react.views.text.ReactRawTextShadowNode; -import com.facebook.react.views.text.ReactSpan; -import com.facebook.react.views.text.ReactStrikethroughSpan; -import com.facebook.react.views.text.ReactTagSpan; -import com.facebook.react.views.text.ReactTextInlineImageShadowNode; import com.facebook.react.views.text.ReactTextViewManagerCallback; import com.facebook.react.views.text.ReactTypefaceUtils; -import com.facebook.react.views.text.ReactUnderlineSpan; -import com.facebook.react.views.text.ShadowStyleSpan; -import com.facebook.react.views.text.TextAttributes; -import com.facebook.react.views.text.TextInlineImageSpan; -import com.facebook.react.views.text.TextInlineViewPlaceholderSpan; import com.facebook.react.views.text.TextTransform; +import com.facebook.react.views.text.internal.span.CustomLetterSpacingSpan; +import com.facebook.react.views.text.internal.span.CustomStyleSpan; +import com.facebook.react.views.text.internal.span.ReactAbsoluteSizeSpan; +import com.facebook.react.views.text.internal.span.ReactBackgroundColorSpan; +import com.facebook.react.views.text.internal.span.ReactForegroundColorSpan; +import com.facebook.react.views.text.internal.span.ReactSpan; +import com.facebook.react.views.text.internal.span.ReactStrikethroughSpan; +import com.facebook.react.views.text.internal.span.ReactTagSpan; +import com.facebook.react.views.text.internal.span.ReactUnderlineSpan; +import com.facebook.react.views.text.internal.span.ShadowStyleSpan; +import com.facebook.react.views.text.internal.span.TextInlineImageSpan; +import com.facebook.react.views.text.internal.span.TextInlineViewPlaceholderSpan; import com.facebook.yoga.YogaDirection; -import com.facebook.yoga.YogaUnit; -import com.facebook.yoga.YogaValue; + import java.util.ArrayList; import java.util.HashMap; import java.util.List; diff --git a/node_modules/react-native-animateable-text/android/src/main/java/com/reactnativereanimatedtext/JBTextShadowNode.java b/node_modules/react-native-animateable-text/android/src/main/java/com/reactnativereanimatedtext/JBTextShadowNode.java index e93a51d..eba97d3 100644 --- a/node_modules/react-native-animateable-text/android/src/main/java/com/reactnativereanimatedtext/JBTextShadowNode.java +++ b/node_modules/react-native-animateable-text/android/src/main/java/com/reactnativereanimatedtext/JBTextShadowNode.java @@ -34,10 +34,10 @@ import com.facebook.react.uimanager.UIViewOperationQueue; import com.facebook.react.uimanager.annotations.ReactProp; import com.facebook.react.uimanager.events.RCTEventEmitter; import com.facebook.react.views.text.FontMetricsUtil; -import com.facebook.react.views.text.ReactAbsoluteSizeSpan; +import com.facebook.react.views.text.internal.span.ReactAbsoluteSizeSpan; import com.facebook.react.views.text.ReactTextUpdate; import com.facebook.react.views.text.ReactTextViewManagerCallback; -import com.facebook.react.views.text.TextInlineViewPlaceholderSpan; +import com.facebook.react.views.text.internal.span.TextInlineViewPlaceholderSpan; import com.facebook.yoga.YogaConstants; import com.facebook.yoga.YogaDirection; import com.facebook.yoga.YogaMeasureFunction; diff --git a/node_modules/react-native-animateable-text/android/src/main/java/com/reactnativereanimatedtext/JBTextViewManager.java b/node_modules/react-native-animateable-text/android/src/main/java/com/reactnativereanimatedtext/JBTextViewManager.java index d2b971a..e847071 100644 --- a/node_modules/react-native-animateable-text/android/src/main/java/com/reactnativereanimatedtext/JBTextViewManager.java +++ b/node_modules/react-native-animateable-text/android/src/main/java/com/reactnativereanimatedtext/JBTextViewManager.java @@ -29,8 +29,8 @@ import com.facebook.react.views.text.ReactTextView; import com.facebook.react.views.text.ReactTextViewManager; import com.facebook.react.views.text.ReactTextViewManagerCallback; import com.facebook.react.views.text.TextAttributeProps; -import com.facebook.react.views.text.TextInlineImageSpan; import com.facebook.react.views.text.TextLayoutManager; +import com.facebook.react.views.text.internal.span.TextInlineImageSpan; import com.facebook.yoga.YogaMeasureMode; import java.util.Map;
Can we get a PR for this please! 🙏
I just tried out the latest version of Expo SDK 51 with react-native 0.74.1 and react-native-animateable-text. During the build process on Android
npx expo run:android
, I receive the following error:Minimal reproducible example: https://github.com/RRaideRR/android-bug-react-native-animateable-text/tree/main