search

axelra-ag / react-native-animateable-text

🆎 A fork of React Native's <Text/> component that supports Animated Values!
https://www.npmjs.com/package/react-native-animateable-text
MIT License
360 stars 27 forks source link

Add text to reanimated addWhitelistedNativeProps #5

Closed owinter86 closed 3 years ago

owinter86 commented 3 years ago

Fixes issue https://github.com/axelra-ag/react-native-animateable-text/issues/4

JonnyBurger commented 3 years ago

Nice! Thanks a lot! I tried it as well, and while it seemed to update the layout (e.g. the viewbox of the text), it somehow did not update the text itself. Does this also happen to you?

However, I did not yet try with Reanimated RC2. I will experiment a bit with it tomorrow.

JonnyBurger commented 3 years ago

I tried with Reanimated RC2 and it works again! Even without whitelisting the props. But this is best practice according to documentation, so I'm going to merge it nonetheless! Hope this way it will not break in the future. Thanks!