axelra-ag / react-native-animateable-text

🆎 A fork of React Native's <Text/> component that supports Reanimated Shared Values as text!
https://www.npmjs.com/package/react-native-animateable-text
MIT License
373 stars 27 forks source link

request react-native v0.75 support #52

Closed LeongXianJun closed 4 weeks ago

LeongXianJun commented 2 months ago

My team is using expo and we are trying to bump our react native to the just released 0.75 version.

When try to run android, we encounter some issues, saying incompatible type.

Seems like on RN0.75, it fails to convert the ReadableMap type to MapBuffer, thus stop the run process.

The following is the log shown on terminal when we try to run android

> Task :react-native-animateable-text:compileDebugJavaWithJavac FAILED
.../node_modules/react-native-animateable-text/android/src/main/java/com/reactnativereanimatedtext/JBTextViewManager.java:105: error: incompatible types: ReadableMap cannot be converted to MapBuffer
        view.getContext(), attributedString, mReactTextViewManagerCallback);
                           ^
.../node_modules/react-native-animateable-text/android/src/main/java/com/reactnativereanimatedtext/JBTextViewManager.java:118: error: incompatible types: ReadableMap cannot be converted to MapBuffer
      TextAttributeProps.getTextAlignment(props, TextLayoutManager.isRTL(attributedString), Gravity.LEFT),
                                                                         ^
.../node_modules/react-native-animateable-text/android/src/main/java/com/reactnativereanimatedtext/JBTextViewManager.java:144: error: incompatible types: ReadableMap cannot be converted to MapBuffer
      localData,
      ^
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Note: Some messages have been simplified; recompile with -Xdiags:verbose to get full output
JonnyBurger commented 2 months ago

I will accept PRs that fix this and make a new release!

Unfortunately I don't use the library anymore

mzaien commented 2 months ago

@JonnyBurger I opened a pr if you can review it https://github.com/axelra-ag/react-native-animateable-text/pull/53#issue-2489157834

LeongXianJun commented 4 weeks ago

I guess this issue is resolved with PR https://github.com/axelra-ag/react-native-animateable-text/pull/53 Thanks everyone for the support