search

axelspringer / graphql-google-pubsub

A graphql-subscriptions PubSub Engine using Google PubSub
MIT License
136 stars 43 forks source link

Updated the README to contain actually functioning code #4

Closed Nift closed 6 years ago

Nift commented 6 years ago

I updated the README to properly import GooglePubSub and not confuse future users.

Using the code in the current README would give a 'library does not have an export named GooglePubSub' erorr. This is due to GooglePubSub being a default export rather than a 'named' export.

jonas-app commented 6 years ago

Ouw, bummer. That wasn't a planned change. Thanks for pointing that out. I think we should change that back to avoid the breaking change. I remember having some trouble with the export in the index file and in the end thought it was a default export. 🙈

Nift commented 6 years ago

Might be a better solution :) However, at the same time it does not seem that there is anything else to import? I am unsure what 'best-practice' would be in this case :)

jonas-app commented 6 years ago

Released as 1.1.1: https://www.npmjs.com/package/@axelspringer/graphql-google-pubsub/v/1.1.1

The change to the default export would be fine, but just with a major release. I might need to look into deprecating npm versions to mark the 1.1.0 version.

jonas-app commented 6 years ago

1.1.0 is deprecated now. Thanks again for pointing this out @Nift.