Closed rabroldan closed 1 year ago
@rabroldan , could you elaborate on the faulty test cases? How did you run your tests?
hi @janosmurai I realized I didnt have the right file uploaded. I uploaded the correct one. with clone being renamed to cp and properly implemented across the project including test files. I apologize for the mistake
I ran the tests with the correct file and now evertyhing passes except for a warning cause by export_cmd which was recently implemented I assume
dem\dem\cli\command\export_cmd.py:17: DeprecationWarning: invalid escape sequence '\^'
No problem, the new status looks much better now!
Could you tell me which Python version you use? Thanks!
hi @janosmurai I used Python 3.11.5 since it required us to use only version 3.10+
hi @janosmurai I used Python 3.11.5 since it required us to use only version 3.10+
You can use that version, but I haven't tested the DEM with a version so high as that. I'll make a new issue for it, nice finding!
Alright, let me know if I missed anything as well.
thank you
@rabroldan , Now LGTM! Thank you for contributing!
Checklist:
Related Issue
Closing: https://github.com/axem-solutions/dem/issues/130 DEM-189
Type Of Change
changed clone command to cp no logic changes required . Error was observed during testing
Description
during testing cp_cmd had worked since it had no changes in logic required but showed two errors during testing
Screenshots (if appropriate):
Additional context Kindly please review thanks