axem-solutions / dem

Containerized Development Environment Manager for embedded development
Other
95 stars 15 forks source link

updated clone cmd to cp #137

Closed rabroldan closed 1 year ago

rabroldan commented 1 year ago

Checklist:

Related Issue

Closing: https://github.com/axem-solutions/dem/issues/130 DEM-189

Type Of Change

changed clone command to cp no logic changes required . Error was observed during testing

Description

during testing cp_cmd had worked since it had no changes in logic required but showed two errors during testing

Screenshots (if appropriate):

image

Additional context Kindly please review thanks

janosmurai commented 1 year ago

@rabroldan , could you elaborate on the faulty test cases? How did you run your tests?

rabroldan commented 1 year ago

hi @janosmurai I realized I didnt have the right file uploaded. I uploaded the correct one. with clone being renamed to cp and properly implemented across the project including test files. I apologize for the mistake

I ran the tests with the correct file and now evertyhing passes except for a warning cause by export_cmd which was recently implemented I assume

dem\dem\cli\command\export_cmd.py:17: DeprecationWarning: invalid escape sequence '\^'

janosmurai commented 1 year ago

No problem, the new status looks much better now!

Could you tell me which Python version you use? Thanks!

rabroldan commented 1 year ago

hi @janosmurai I used Python 3.11.5 since it required us to use only version 3.10+

janosmurai commented 1 year ago

hi @janosmurai I used Python 3.11.5 since it required us to use only version 3.10+

You can use that version, but I haven't tested the DEM with a version so high as that. I'll make a new issue for it, nice finding!

rabroldan commented 1 year ago

Alright, let me know if I missed anything as well.

thank you

janosmurai commented 1 year ago

@rabroldan , Now LGTM! Thank you for contributing!