axemclion / browser-perf

Performance Metrics for Web Browsers
BSD 2-Clause "Simplified" License
937 stars 61 forks source link

Unable to open edge or ie #89

Open malled opened 6 years ago

malled commented 6 years ago

I am trying to use browser-perf with edge or ie but unfortunately it doesn't work. Chrome always opens.

Starting selenium server with java -Dwebdriver.edge.driver="edgedriver.exe" -Dwebdriver.ie.driver="iedriver.exe" -jar selenium-server-standalone-3.6.0.jar

Executing browser-perf: browser-perf -c browser-perf.json http://www.google.com

json content:

{
    "browsers": [{
        "browserName": "internet explorer"
    },
    {
        "browserName": "edge"

    }],
    "selenium": {
        "hostname": "localhost",
        "port": 4444
    }
}

Edge or IE doesn't open; instead, chrome opens Selenium log looks like this:

16:06:25.621 INFO - Capabilities {loggingPrefs={performance=ALL}, browserName=internet explorer, javascriptEnabled=true, chromeOptions={perfLoggingPrefs={}}, platformName=ANY, version=, platform=ANY, } matched class org.openqa.selenium.remote.server.ServicedSession$Factory (provider: org.openqa.selenium.chrome.ChromeDriverService)
Starting ChromeDriver 2.33.506120 (e3e53437346286c0bc2d2dc9aa4915ba81d9023f) on port 5495
Only local connections are allowed.

how can i get edge working?

axemclion commented 6 years ago

Can you run browser-perf with set DEBUG=* ? That should give us the string used for selenium options.

malled commented 6 years ago

browser-perf -c browser-perf.json http://www.google.de

Error: [eval("(window.__scrollActionDone === true)")] Error response status: 100,  Selenium error: chrome not reachable
  (Session info: chrome=61.0.3163.100)
  (Driver info: chromedriver=2.33.506120 (e3e53437346286c0bc2d2dc9aa4915ba81d9023f),platform=Windows NT 10.0.15063 x86_64)
axemclion commented 6 years ago

@malled Thanks - looks like somewhere in the code, we are not respecting other browsers being sent. I may not have time to look into this, but would be open to get a pull request. I think the best place to start would be the index file. It is very likely that the error is somewhere in the place where the default options are set.

malled commented 6 years ago

I've looked into it and your code seems to be fine. May this issue be related to selenium? Do you have any advise to debug this?