search

axemclion / grunt-saucelabs

Grunt task for running all your browser tests using Sauce Labs
MIT License
182 stars 98 forks source link

incoming-pr branch is outdated, so that it is impossible to foollow guidelines for contributing #198

Open evilaliv3 opened 8 years ago

evilaliv3 commented 8 years ago

incoming-pr branch, cited by guidelines for contributing

i think you should take care of changin the guidelines if no more needed or rebase the incoming-pr branch to latest master.

spotted while trying to following the guidelines for opening the pull request: https://github.com/axemclion/grunt-saucelabs/pull/197

\cc @axemclion @Jonahss

axemclion commented 8 years ago

@Jonahss Should we revise the guidelines ? I think we should simply ask for PRs to be against master. I had originally done the incoming-pr branch so as to not break master, and have the sauce key private, but clearly that did not work.

Jonahss commented 8 years ago

Yeah we can just edit the docs and go to a regular PR to master system.

On Fri, Jan 8, 2016 at 8:14 AM, Parashuram N notifications@github.com wrote:

@Jonahss https://github.com/Jonahss Should we revise the guidelines ? I think we should simply ask for PRs to be against master. I had originally done the incoming-pr branch so as to not break master, and have the sauce key private, but clearly that did not work.

— Reply to this email directly or view it on GitHub https://github.com/axemclion/grunt-saucelabs/issues/198#issuecomment-170043848 .