axemclion / grunt-saucelabs

Grunt task for running all your browser tests using Sauce Labs
MIT License
182 stars 98 forks source link

Update docs to avoid deprecated config options #208

Open garex opened 8 years ago

garex commented 8 years ago

As I understand video-upload-on-pass: false is extra-deprecated and now we should use recordVideo: false.

It would be good to update all docs and examples with actual config params.

eugenet8k commented 8 years ago

I got a problem recently, not sure if it's related to this issue. Basically when I set:

'saucelabs-mocha'
  all: 
    options: 
      recordVideo: false 
      videoUploadOnPass: false 
      recordScreenshots: false 

It seems these are being ignored, and saucelabs still record video. I created a ticket on saucelabs for that and they say:

You're right, it looks like we're not being sent those config values by your tests at all.

We're not able to provide more then cursory support for external libraries and tools but I think I might have an idea what's happening here anyway; Assuming you're using https://github.com/axemclion/grunt-saucelabs it looks like you need to add a sauceConfig key to Options, setting it to a map of the additional options to pass, eg

options: { username: # and so on sauceConfig: { 'recordVideo': true, 'recordScreenshots': false } }

Give that a try, and if it doesn't work, I'd suggest raising a bug against the tool you're using and asking the author for assistance.

Therefore I am wondering, where I actually should define this recordVideo param? Thanks for all help.

garex commented 8 years ago

Here are my working options:

https://github.com/garex/angular-sorted-map/blob/25326165ab7f6ccab375fc817ca83440a6626997/GruntFile.js#L54:L57

eugenet8k commented 8 years ago

@garex thanks. that worked well!