axemclion / grunt-saucelabs

Grunt task for running all your browser tests using Sauce Labs
MIT License
182 stars 98 forks source link

Handle 'test error' to deal with error response from invalid browsers. #225

Closed jbeard4 closed 7 years ago

jbeard4 commented 7 years ago

Tested with configuration:

      'saucelabs-custom': {
        all: {
          options: {
            urls: [
              'http://127.0.0.1:3000/'
            ],
            browsers: [
              {
                browserName : 'chrome',
                platform : 'OS X 10.11',
                version : 26 
              }
            ],
            statusCheckAttempts : -1
          }
        }
      }

Chrome 26 on OS X 10.11 is unsupported by sauce labs. Returns a response where result.status is "test error". Expected behavior: test fails with an error. Actual behavior: request will be re-attempted, and when statusCheckAttempts is set to -1, the test will never complete.

This PR causes the test to complete with an error.

jbeard4 commented 7 years ago

I just noticed, this is a duplicate of #224