search

axemclion / jquery-indexeddb

An IndexedDB Plugin for Jquery.
Other
195 stars 71 forks source link

Fixed IDBCursor.NEXT and fixed some other minor things #22

Closed rmobis closed 11 years ago

rmobis commented 11 years ago

Fixed the IDBCursor.NEXT constant, which was broken since the last commit and added some semicolons and removed unnecessary ones, in order to clean the code. I know some of these are a matter of opinion, so merge it if you like it.

I'm new to GitHub, so let me know me if I'm doing anything wrong.

rmobis commented 11 years ago

It says the Travis build failed, but I've got no idea of what that is.

axemclion commented 11 years ago

Can you squash your commits into a single commit ? Also, looks like there were changes to spacing, which result in the diff showing up the whole file. I am not able to see the changes you made.

About the travis build, don't worry about it - I will be disabling it for pull requests, and will only enabling linting.

Also, I am using semi-colons based on the lint file defination. You could try grunt lint on your command line to see if your code lints well.

axemclion commented 11 years ago

Corrected the spaces/tabs issue, merged this request. Thankyou

rmobis commented 11 years ago

Oh, thanks. I was writing a long and complicated comment about it, but well, good thing you sorted it out. I know this wasn't a huge contribution, but I plan on keep helping.

axemclion commented 11 years ago

@rmobis Thanks for helping me out here ... I just missed that - stupid mistake on my part :)