search

axemclion / jquery-indexeddb

An IndexedDB Plugin for Jquery.
Other
195 stars 71 forks source link

Tests are failing in Chrome #3

Closed juzerali closed 12 years ago

juzerali commented 12 years ago

Chrome Dev: 18.0 Windows 7

Tests 6.2, 7.1, 16.2, 23.2, 27.7, 27.8 are failing. Surprisingly when I run the tests in Incognito mode, only 6.2-, 7.1, 16.2, and 23.2 fails.

However on Canary 6.2, 7.1, 12.1, 13.1, and 15.1 are failing. Canary: 20.0

axemclion commented 12 years ago

Thnx for reporting this - will be looking into it.

axemclion commented 12 years ago

Corrected failing tests 6.2 and 7.1 - the test cases were badly written.

Tests 16.2 will fail as there is no Advance in chrome yet. Will need to provide a fallback for this, but not sure how well used, the cursor.advance is.

Test 23.2 is failing due to the way the test it written. I think that this test should be kept as that is not the right way to call abort for Chrome.

axemclion commented 12 years ago

Fixed test 27 in https://github.com/axemclion/jquery-indexeddb/commit/37b7ea5c6b866321675bca56ce6c662a8761b5f4

juzerali commented 12 years ago

Thanks mate, does it mean that we can use this plugin in Chrome, without advanced cursors of course?

axemclion commented 12 years ago

Yes, that is correct. All tests are passing.