search

axemclion / perfjankie

Checking browser rendering performance regression
343 stars 25 forks source link

Consider making title configurable #18

Open arschmitz opened 9 years ago

arschmitz commented 9 years ago

It seems like right now the test page title is just the file name from the url. This causes several potential issues.

1.) A page which contains a query string breaks results. I tried to use a page like component.html?component=button&framework=bootstrap&count=1000 to have a pages which generates the pages to be tested. however because the results are displayed as the filename nad used in a query string to show results you end up with something like

http://104.236.81.132:5984/css-perf/_design/site/index.html#/summary?pagename=component.html?component=button&framework=bootstrap&count=1000&browser=chrome which is not valid and just displays an error

2.) it can make for ugly names and organization when you have a lot of tests your running for comparison of individual components.

For now to work around this im using urls like http://localhost/component/button/framework/bootstrap/count/1000/bootstrap:button to work around this but it requires all the urls to be re-written. The easy solution seems like it would be to just use the actual page title instead of the file from the url?

axemclion commented 9 years ago

This was a regression. Note that the tool can not just run for a single page, but for a whole set of pages (like a checkout workflow). The database has a "name" field, that I was planning to use, if the URL was not available. I think the "name" basically identifies the "page". Additionally, there definitely needs to be URL escaping also.