axemclion / react-native-cordova-plugin

Cordova Plugin Adapter for React Native
ISC License
440 stars 35 forks source link

Update Readme for Plugin Variable Support #30

Closed c-h- closed 8 years ago

axemclion commented 8 years ago

@c-h- Quick question on this PR - I see that the part where you have implemented the actual logic in android-cli.js is already merged. I see it in the master branch and that PR says that it is merged. Are you not seeing it ?

I see that this PR has the README.md changes, in addition to that logic - and I don't see any merge conflicts.

axemclion commented 8 years ago

@c-h- Nevermind - though the logic was merged in #27, and I still see the changes here, looks like there was no merge issue, so life is good :)