search

axheron / ffxiv-dps-calc

A Final Fantasy XIV DPS simulator for comparing gear sets
https://dpscalc.xivresources.com
GNU Affero General Public License v3.0
2 stars 4 forks source link

Accessibility fixes to the UI #92

Closed Juanaxu closed 3 years ago

Juanaxu commented 3 years ago

Wrapped every clickable thing in a element so they're focusable, screen readers know they're clickable, and have basic browser accessibility functionality. Added alt text to buff images. Added label text to the inputs when editing a gearset.

ackao commented 3 years ago 
Error: src/app/rotation-options/rotation-options.component.html:2:46 - error TS2339: Property 'SCHOLAR' does not exist on type 'typeof import("/home/runner/work/***/***/client/src/app/data/job")'.

2      *ngIf="dpsService.selfJob === jobConsts.SCHOLAR.name">
                                               ~~~~~~~

  src/app/rotation-options/rotation-options.component.ts:11:16
    11   templateUrl: './rotation-options.component.html',
                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    Error occurs in the template of component RotationOptionsComponent.