search

axiacore / py-expression-eval

MIT License
149 stars 54 forks source link

Make string literal quote types configurable #63

Closed laurence-hudson-mindfoundry closed 3 years ago

laurence-hudson-mindfoundry commented 3 years ago

I'm looking to upgrade from v0.3.5 to latest. However, the changes in v0.3.9 (#47) break compatibility with existing functions my users have written, and aren't a good fit for my usecase where the keys in the values dict are human readable strings, frequently containing spaces.

This PR makes it trivial to opt out of the breaking change in 0.3.9.

Looks like others may also have encountered and/or would benefit from this too (#62, maybe even #38?)

If your happy with this added flexibility I'd really appreciate a 0.3.11 release with it in.

laurence-hudson-mindfoundry commented 3 years ago

@cansadadeserfeliz Any chance of this getting looked at?

cansadadeserfeliz commented 3 years ago

@laurence-hudson-mindfoundry thanks and sorry for the delay!