search

axiak / pyre2

Python wrapper for RE2
BSD 3-Clause "New" or "Revised" License
295 stars 39 forks source link

pyre2 not working for match and search #11

Closed aih closed 12 years ago

aih commented 12 years ago

I've been using the pyre2 module successfully for a while; however, I recently updated both re2 and pyre2 yesterday, and it is not working for simple match and search functions. E.g. python re2.match('this', 'thisthat') prints a 1, but does not return anything.

axiak commented 12 years ago

I just posted a fix. Just curious, was this broken in a release? I'm pretty sure this was just development noise on master.

aih commented 12 years ago

Thanks, Michael! I'm not sure if this answers your question, but I tried to install from pip and got an error related to pip.log. Then I downloaded and installed from master.

For future, how can I install a release version? The one on pypi is 2.20

seanfarley commented 12 years ago

Sorry for such a late reply to a closed thread but I just wanted to confirm that this bug does indeed exist in the pypi version 2.20.

aih commented 12 years ago

Thanks Sean. It's never too late to get confirmation that I was not imagining things...

mikelambert commented 9 years ago

@axiak , this still appears broken in the 2.20 release on pypi (ie, not development noise on master). However, downloading from github and installing it myself, seems to work.

What is the process for pushing a new version to pypi?

ralphbean commented 9 years ago

Ping. I'm hitting the same issue. @axiak, can you cut a new release?

ViachKakovskyi commented 9 years ago

@ralphbean ++

ralphbean commented 9 years ago

So, I met the fb-re2 guys at PyCon and they're on top of things. I recommend you use their pypi package which 1) works correctly and 2) is up to date and maintained: https://pypi.python.org/pypi/fb-re2

axiak commented 9 years ago

fixed

ViachKakovskyi commented 9 years ago

Thanks!