search

axic / scrypt.js

Scrypt in Node.js and in the browser. Fast & simple.
MIT License
4 stars 7 forks source link

Turn this library into a scryptsy wrapper #6

Closed alcuadrado closed 5 years ago

alcuadrado commented 5 years ago

IFAIK this library isn't maintained anymore, but it's still being used by most javascript-based Ethereum projects. This is a problem, as it doesn't support node 12.

scrypt, one of this library's dependencies is deprecated, so it won't support node 12.

This PR turns this library into a simple scryptsy wrapper, to be published as a patch version. This way most projects will start using this version and get support for node 12. Releasing it this way can have a performance impact of some users, but I believe that would be a better situation than the current one (i.e. people with node 12 not being able to install most things).

I will prepare a similar PR for 0.2.x, as many projects still use that version.

alcuadrado commented 5 years ago

Update: I think the main problem is with version 0.2.x, as this one has scrypt as an optionalDependency

axic commented 5 years ago

WARNING!!! This module is deprecated. Instead, use https://nodejs.org/api/crypto.html#crypto_crypto_scrypt_password_salt_keylen_options_callback

This is the warning on scrypt. I'd prefer to support scryptsy + crypto.scrypt instead of scrypt then.

@alcuadrado can you make that change?

alcuadrado commented 5 years ago

Sure, I'll close this PR and make a new one later today/tomorrow.