search

axieax / urlview.nvim

🔎 Neovim plugin for viewing all the URLs in a buffer
MIT License
232 stars 5 forks source link

Prefix `www` urls with `https://` #17

Closed smithbm2316 closed 2 years ago

smithbm2316 commented 2 years ago

Fixes follow-up issue discussed in #7, until I read the codebase I did not realize that this would be such a simple fix 😆

smithbm2316 commented 2 years ago

I will work on getting the tests to pass later tonight (heading to dinner)! Looks like I had a bit of an oversight here on how simple it would be

axieax commented 2 years ago

It's expected that the tests fail because they longer account for the default_prefix. Could you also make default_prefix a config option, so we are able to test it using a before_each setup.

Update: I'll clean up the tests rn

smithbm2316 commented 2 years ago

@axieax is the latest commit what you were thinking? I probably should've just let you handle it since it seems like you knew exactly what you wanted to change 😆

axieax commented 2 years ago

That's exactly what I wanted thanks ahaha! I've updated the tests as well from my end, not too sure how I can add commits to this PR though.

smithbm2316 commented 2 years ago

oh yeah...i can give you push access to my fork probably and then you can just add a commit to main there. give me a sec

EDIT: i've sent you an invite to be a collaborator to that repo. you should be able to push to main and then it will show up here :)

axieax commented 2 years ago

Thanks for that! I've added the commit now. If you're happy with the changes, I'll merge it in :))

smithbm2316 commented 2 years ago

Yeah! Looks good to me 😄

axieax commented 2 years ago

Tysm for the help :))