search

axieax / urlview.nvim

🔎 Neovim plugin for viewing all the URLs in a buffer
MIT License
232 stars 5 forks source link

feat: support Windows #42

Closed lopi-py closed 1 year ago

lopi-py commented 1 year ago

closes #41

axieax commented 1 year ago

From memory, 'start' for the windows condition should be enough (without the /C hack), so a two line change would suffice for this feature - another case for os:match("Windows") -> calls start.

lopi-py commented 1 year ago

I tried but it doesnt work image also executable("start") returns 0 which means false

axieax commented 1 year ago

I tried but it doesnt work

image

also executable("start") returns 0 which means false

Are you using WSL or Windows?

lopi-py commented 1 year ago

Windows, on WSL xdg-open is used

axieax commented 1 year ago

Just curious are you using the raw nvim release binary or a graphical client?

lopi-py commented 1 year ago

Now I'm using raw neovim but usually I use neovide

axieax commented 1 year ago

Ok I've refactored a few things. Could you please add me as a collaborator to your fork? Just want to test a quick thing before merging :))

lopi-py commented 1 year ago

Done

axieax commented 1 year ago

Can you have a check if this works now :))

lopi-py commented 1 year ago

it works

axieax commented 1 year ago

Perfect! Thanks for confirming and for the PR!! :))