search

axieax / urlview.nvim

🔎 Neovim plugin for viewing all the URLs in a buffer
MIT License
230 stars 5 forks source link

Does not work on my system, since xdg-open in my nvim does not work. Please wrap xdg-open in jobstart #64

Open cmon1701 opened 1 month ago

cmon1701 commented 1 month ago

As described here, xdg-open does not work within nvim on some systems. https://github.com/neovim/neovim/issues/19724

Please implement the solution https://github.com/neovim/neovim/issues/19724#issuecomment-1267261673 in this plugin (:call jobstart('xdg-open ').

Thanks!

axieax commented 1 month ago

Hey, I've implemented a fix for this in the jobstart branch (#65). I'm a bit hesitant on merging this since there is quite a bit of hacky code to get errors to be displayed as expected, and the nvim documentation recommending system() over jobstart() for lua contexts. Furthermore, I'm unable to test this on Windows atm, so not sure if this will break things there as well. Feel free to use the branch until this issue gets resolved (and please let me know if there's an alternative to jobstart)!