all: rework genesis api

axieinfinity / ronin

A DPoS blockchain.

GNU Lesser General Public License v3.0

67 stars 30 forks source link

Closed Francesco4203 closed 1 month ago

Francesco4203 commented 1 month ago

This PR refers to the 2 following PRs:

https://github.com/ethereum/go-ethereum/pull/24460: allow recommitting genesis state in case of rewinding to it. The current code assume genesis state is always in the database, but PBSS might overwrite the old states.
https://github.com/ethereum/go-ethereum/pull/25473: rework a few things:
- ToBlock is now only used to generate genesis block, since we have Flush to write to db
- Remove GenesisBlockForTesting

huyngopt1994 commented 1 month ago

Founding some places impacted to rewind logic here, maybe need to retest again after merging.

huyngopt1994 commented 1 month ago

I rechecked the logic of refactoring, seem it's safe for merging. LGTM.