trie: refactor tracer - Githubissues

Francesco4203 commented 1 month ago

Changes:

Rename trie/utils.go to trie/tracer.go
Rename origin field in tracer to accessList, still the same function
Merge updated nodes and deleted nodes to the same list of dirty nodes, still keep track of number of deleted and updated nodes. List of dirty nodes is map from path to node, an empty node meaning a deleted node. Same logic for merging markUpdated and markDeleted into addNode
committer: move logic to mark deleted nodes to committer.store for consistency with the mark update logic

huyngopt1994 commented 1 month ago

One thing note here in PR is tracer is enabled by default

    trie := &Trie{
        owner:  id.Owner,
        reader: reader,
        //tracer: newTracer(),
        tracer: newTracer(),
    }

huyngopt1994 commented 1 month ago

I think u should spit one commit in the PR into more commits for easily reviewing, merging into one 's hard for understanding the purpose of changes.

axieinfinity / ronin