'Black theme variant' overlaps light theme

axiel7 / AniHyou-android

Another unofficial Android AniList client

https://axiel7.github.io/anihyou/

GNU General Public License v3.0

276 stars 5 forks source link

'Black theme variant' overlaps light theme #145

Closed akyraisconfused closed 1 month ago

akyraisconfused commented 1 month ago

Describe the bug (required) When switching to light theme with 'Black theme variant' enabled, some elements switch to their light theme colors but the background stays black.

To Reproduce

Go to AniHyou's settings
Enable 'Black theme variant'
Switch to light theme

Steps 2 and 3 are interchangeable.

Expected behavior Background turning light.

Screenshots Screenshot_20240603_181220_AniHyou

Enviroment (required)

Device model: Samsung Galaxy S22 (SM-S901E/DS)
Android version: Android 14, April Security Patch
App version: 1.3.1

axiel7 commented 1 month ago

Mmm I can't reproduce this on my device. If you restart the app it stays the same?

akyraisconfused commented 1 month ago

yup, i cleared data in an attempt to fix a bug with lists (which worked) but this still happens. maybe i'll try reinstalling.

axiel7 commented 1 month ago

Nah this is problably a bug with OneUI, I'll block that option in light mode

akyraisconfused commented 1 month ago

yeah gave it a try on my Tab A 2019 and the same result, definitely a Samsung issue like the Material You one.

axiel7 commented 1 month ago

Beta 1.3.2 should fix this

akyraisconfused commented 1 month ago

~strangely enough this still occurs for me on 1.3.2~ oh wait, the commit disables it when the device theme is light, not the app. that should be fine 👍