axieum / authme

:lock: Authenticate yourself in Minecraft and re-validate your session
https://www.curseforge.com/minecraft/mc-mods/auth-me
MIT License
92 stars 34 forks source link

Disconnected screen crashes the game when adding the re-login button #87

Closed AnAwesomGuy closed 1 year ago

AnAwesomGuy commented 1 year ago

Expected behavior

show the disconnected screen

Observed/actual behavior

game crashed and showed "saving world" for a split second

Steps/models to reproduce

join a server get kicked see that the game crashes

Version

7.0.0

Agreements

Other

crash-2023-06-10_11.18.28-client.txt looks like this mixin is crashing it says that a TextWidget cannot be cast to a ButtonWidget in the DisconnectedScreen,

AnAwesomGuy commented 1 year ago

also, it does show "Adding auth button to the disconnected screen"

axieum commented 1 year ago

Thanks for reporting this @AnAwesomGuy. Please find the working version here: https://modrinth.com/mod/auth-me/version/7.0.1+1.20

AnAwesomGuy commented 1 year ago

wait that was actually just fixable by changing a single number?

axieum commented 1 year ago

Yeah, it looks like they added a couple labels before the buttons on that screen. Ideally, could iterate through the elements for the first ButtonWidget but this was the quickest fix.