axieum / authme

:lock: Authenticate yourself in Minecraft and re-validate your session
https://www.curseforge.com/minecraft/mc-mods/auth-me
MIT License
85 stars 32 forks source link

Modrinth description has incorrect HTML in `<img>` tag #96

Closed James103 closed 1 year ago

James103 commented 1 year ago

Expected behavior

In the Modrinth description, there should be a GIF showing some of the possibilities of the Auth Me mod.

The relevant raw HTML should be as follows:

<img alt="Auth Me Demo" src="https://github.com/axieum/authme/raw/main/demo.gif" width="50%" align="right">

Observed/actual behavior

The above HTML is incorrectly typed and displays as is:

<img alt="Auth Me Demo" src="https://github.com/axieum/authme/raw/main/demo.gif" width="50%" align="right>

(missing double quotes " near the end).

Steps/models to reproduce

Check the Modrinth description for the mod: https://modrinth.com/mod/auth-me

Version

authme-7.0.2+1.20.jar (assumed latest) Issue is with mod description, accessed 7 July 2023.

Agreements

Other

No response

axieum commented 1 year ago

Thank you for pointing this out. I've gone ahead and manually updated it, however it will break again on the next release.

https://github.com/axieum/authme/blob/a1f44fdfe3416483d2394f506a1a30e9b237e9b8/build.gradle#L217-L218

I wonder if Minotaur is preprocessing relative links in the markdown?

axieum commented 1 year ago

Minotaur mentions this:

This does not occur with the modrinth task; you must use the modrinthSyncBody task separately to accomplish this.