search

axiom-crypto / halo2-lib

Monorepo of halo2 crates
MIT License
238 stars 151 forks source link

`CopyConstraintManager` should contain `witness_gen_only` #210

Open jonathanpwang opened 1 year ago

jonathanpwang commented 1 year ago

Since it is shared everywhere, it should have the source of truth so different structs don't need to individually hold their own trackers of witness_gen_only.

nyunyunyunyu commented 1 year ago

Should CircuitBuilder not have witness_gen_only?

jonathanpwang commented 1 year ago

The problem is we often have different virtual region managers and they each need to know about witness_gen_only. I think we've been encountering a bunch of places where it's inconvenient to also pass it in or make sure CircuitBuilder is always accessible?