fix : `num_limbs_log2_ceil`

axiom-crypto / halo2-lib

Monorepo of halo2 crates

MIT License

236 stars 145 forks source link

Closed enricobottazzi closed 7 months ago

jonathanpwang commented 8 months ago

Could you explain this PR? num_limbs_log2_ceil is not a function I believe. bit_length can be 1 greater than log2_ceil, if that is the fix?

enricobottazzi commented 8 months ago

You're right. I meant to use log2_ceil() util instead.

As you mentioned, the fix relates to the possible discrepancy between bit_length and log2_ceil.

If this makes sense to you, I can go ahead and fix it.

jonathanpwang commented 7 months ago

Ok I checked and I think using log2_ceil from util would be correct. Please make the fix