Closed drcapybara closed 5 months ago
Thanks - not pinning a nightly version likely leads to problems down the line. Do you know what dependency is importing clap? It seems to be a consistent source of problems, so it'd be preferable to remove it if possible.
Otherwise, we can re-pin the rust toolchain to a newer nightly.
Do you know what dependency is importing clap?
Its coming in from Criterion v0.5.1 which is the latest version:
[dev-dependencies]
├── criterion v0.5.1
│ ├── anes v0.1.6
│ ├── cast v0.3.0
│ ├── ciborium v0.2.2
│ │ ├── ciborium-io v0.2.2
│ │ ├── ciborium-ll v0.2.2
│ │ │ ├── ciborium-io v0.2.2
│ │ │ └── half v2.3.1
│ │ │ └── cfg-if v1.0.0
│ │ └── serde v1.0.196 (*)
│ ├── clap v4.5.0
│ │ └── clap_builder v4.5.0
│ │ ├── anstyle v1.0.6
│ │ └── clap_lex v0.7.0
These features are identified as requiring nightly FYI:
#![feature(slice_group_by)]
#![feature(trait_alias)]
#![feature(slice_group_by)]
Ah got it, can you change the rust-toolchain to specify a date so we can pin it, and then also pin the criterion version with =0.5.1
so hopefully future updates don't break things again? Thanks!
Ah got it, can you change the rust-toolchain to specify a date so we can pin it, and then also pin the criterion version with
=0.5.1
so hopefully future updates don't break things again? Thanks!
Criterion version appears pinned already. PR pins nightly as of today.
noticing a ton of redundant imports and other clippy CI violations now that rustc is pinned to nightly. @jonathanpwang we can either fix those or pin to a different nightly that is compatible with clap
@drcapybara maybe we can just add clap
as a dev dependency and pin the version to something before 4.5.0
running benches:
is currently failing to build:
PR simply updates to nightly in rust-toolchain