axiom-data-science / extract_model

Facilitates read-in and extraction for ocean model output.
https://extract-model.readthedocs.io/
MIT License
5 stars 4 forks source link

preprocessing updates for roms #95

Closed kthyng closed 1 year ago

kthyng commented 1 year ago

Pull Request Reminders

codecov[bot] commented 1 year ago

Codecov Report

Attention: 60 lines in your changes are missing coverage. Please review.

Comparison is base (f44cc30) 84.71% compared to head (5c17937) 82.31%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #95 +/- ## ========================================== - Coverage 84.71% 82.31% -2.40% ========================================== Files 20 20 Lines 1753 1764 +11 ========================================== - Hits 1485 1452 -33 - Misses 268 312 +44 ``` | [Flag](https://app.codecov.io/gh/axiom-data-science/extract_model/pull/95/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=axiom-data-science) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/axiom-data-science/extract_model/pull/95/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=axiom-data-science) | `82.31% <3.22%> (-2.40%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=axiom-data-science#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/axiom-data-science/extract_model/pull/95?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=axiom-data-science) | Coverage Δ | | |---|---|---| | [extract\_model/preprocessing.py](https://app.codecov.io/gh/axiom-data-science/extract_model/pull/95?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=axiom-data-science#diff-ZXh0cmFjdF9tb2RlbC9wcmVwcm9jZXNzaW5nLnB5) | `39.68% <3.22%> (-19.87%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/axiom-data-science/extract_model/pull/95/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=axiom-data-science)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.