SPS's height/width parsing is not completely correct

axiomatic-systems / Bento4

Full-featured MP4 format, MPEG DASH, HLS, CMAF SDK and tools

http://www.bento4.com

1.98k stars 480 forks source link

Open roticv opened 7 years ago

roticv commented 7 years ago

There are corner cases that the height and width is not computed correctly from the h264 SPS because the chroma_format_idc is not taken into account. See https://chromium.googlesource.com/external/webrtc/trunk/webrtc/+/master/common_video/h264/sps_parser.cc for more information about the correct handling

barbibulle commented 7 years ago

Thanks for the pointer. I'll fix this ASAP. Do you have a sample file that can be used for testing this case?