axiomatic-systems / Bento4

Full-featured MP4 format, MPEG DASH, HLS, CMAF SDK and tools
http://www.bento4.com
2.03k stars 483 forks source link

Update dashif:laurl to dashif:Laurl per latest specification #953

Open gmcgarry opened 7 months ago

gmcgarry commented 7 months ago

See discussion here: https://github.com/Dash-Industry-Forum/dash.js/issues/4459

mp4-dash.py creates a element with the URL to the clearkey license server. The name of this element has been updated in the spec to . There are a few other changes for the clear-key case.

Here is at patch:

diff --git a/Source/Python/utils/mp4-dash.py b/Source/Python/utils/mp4-dash.py
index 70ac4a6..5d42860 100755
--- a/Source/Python/utils/mp4-dash.py
+++ b/Source/Python/utils/mp4-dash.py
@@ -312,7 +312,7 @@ def AddContentProtection(options, container, tracks, all_tracks):
             ck_license.text = options.clearkey_license_uri

             # Second entry with the dashif namespace
-            ck_license = xml.SubElement(cp, '{'+DASHIF_NAMESPACE+'}laurl')
+            ck_license = xml.SubElement(cp, '{'+DASHIF_NAMESPACE+'}Laurl')
             ck_license.text = options.clearkey_license_uri

     # Marlin