search

axiomhq / axiom-grafana

The official Axiom datasource plugin for Grafana.
https://axiom.co
Apache License 2.0
6 stars 3 forks source link

chore: enable overriding the default api host #19

Closed a-khaledf closed 1 year ago

a-khaledf commented 1 year ago

If we are using axiom grafana datasource in watchtower.dev.axiomtestlabs.co without this PR, we won't be able to hit api.dev.axiomtestlabs.co

dasfmi commented 1 year ago

@a-khaledf there was a decision against showing the users this option, that's why we added the condition. Since we don't support self-host anymore, I think this might be confusing for users. maybe we can have another variable during build or something that would be used to show/hide this field.

mschoch commented 1 year ago

@a-khaledf @schehata could we instead extend the check to allow for window.location.hostname to either be localhost, or end with suffix axiomtestlabs.co?

a-khaledf commented 1 year ago

Yes, great idea. let's do that for now