Closed lucassmuller closed 1 month ago
I updated the pnpm lock file on main, can you please rebase this PR, I will approve the CI again once its ready.
I updated the pnpm lock file on main, can you please rebase this PR, I will approve the CI again once its ready.
done
btw the root cause of this problem is actually the following code line
probably i should adjust it there. thoughts?
I updated the pnpm lock file on main, can you please rebase this PR, I will approve the CI again once its ready.
done
btw the root cause of this problem is actually the following code line
probably i should adjust it there. thoughts?
yeah, here it would with other transports as well, not just winston. go for it 👍
Do you have a test case that we can apply here?
I updated the pnpm lock file on main, can you please rebase this PR, I will approve the CI again once its ready.
done btw the root cause of this problem is actually the following code line https://github.com/axiomhq/axiom-js/blob/70c846719f3b4fd2e05475787f368af5189f476b/packages/js/src/client.ts#L163
probably i should adjust it there. thoughts?
yeah, here it would with other transports as well, not just winston. go for it 👍
Do you have a test case that we can apply here?
Done
thanks @lucassmuller , that looks great. It will be in the upcoming release.
Issue: Current
JSON.stringify
doesn't support bigints. This results in logs not being sent to Axiom.Solution: Implement
toJSON
function in BigInt prototype so they can be stringified.