init sveltekit library - Githubissues

axiomhq / axiom-js

Official language bindings and library extensions for Axiom

https://axiom.co

MIT License

85 stars 13 forks source link

Open schehata opened 1 month ago

schehata commented 1 month ago

Create a library to support logging from sveltekit.

jerriclynsjohn commented 3 weeks ago

I'm looking at the example code, and I want this. Been waiting for this for a while. Let's go @schehata!!!!

jerriclynsjohn commented 3 weeks ago

I'd also like to know how this will work with my Sentry integration! How will Sentry and Axiom handle the handleError hook together?

jerriclynsjohn commented 3 weeks ago

I'd also like to know how this will work with my Sentry integration! How will Sentry and Axiom handle the handleError hook together?

Figured it out. I can pass custom error handler to handleErrorWithSentry()

jerriclynsjohn commented 3 weeks ago

@schehata I have made some changes to the codebase based on the discussion in this PR. I've also made PR #207 for it.

schehata commented 1 week ago

@jerriclynsjohn I have update the README, to give us a starting doc. We will have to improve, and hopefully @tothmano when he is back.

There is 2 things that we need to do, and then its ready in my opinion:

Think of how users will import the logger in their pages/components and provide & example
Implement web-vitals and send them to Axiom. We can probably use web-vitals npm package, the question is, where in a svelte-app would this live?

schehata commented 1 week ago

aaah, the build process is trying to send logs to Axiom, not sure if we want that: https://github.com/axiomhq/axiom-js/actions/runs/9838268413/job/27157798727?pr=198