search

axiomhq / axiom-js

Official language bindings and library extensions for Axiom
https://axiom.co
MIT License
92 stars 14 forks source link

Fixing Sveltekit package and example issues #207

Closed jerriclynsjohn closed 2 months ago

jerriclynsjohn commented 3 months ago

As discussed in #198 I'm adding the suggested changes.

SollyzDev commented 3 months ago

hey @jerriclynsjohn, great work! I see you are very excited for this, I will take a look in the next couple of days and help get this released 👍

jerriclynsjohn commented 3 months ago

The PR looks good, there is one thing I am concerned about. The source field, I wanted to make that as simple and limited as possible so that we can build dashboards easily using it. I imagine hooks-server and hooks-client + others, will make it more complex, we need to think how to simplify this. maybe ['source'] + ['browser'] would indicate if its a client or server. or maybe we can introduce a filename field or something? wdyt?

['source'] + ['browser'] sounds like a good strategy. So in this setup source can be just hooks.

jerriclynsjohn commented 3 months ago

It would actually help to custom name it in handleError in hooks. To enable us to filter errors that happened from hooks.

SollyzDev commented 3 months ago

It would actually help to custom name it in handleError in hooks. To enable us to filter errors that happened from hooks.

Lets start with just hooks in first version, then lets think how can we improve it. But, if the name is always hooks for example, then at Axiom we can build a dynamic dashboard that works for everyone

jerriclynsjohn commented 3 months ago

@schehata Renamed it all to just hooks