I also addressed the linter issues. However, one test is failing. Not because of my change, tests were not passing for main, either. One interesting thing: After I addressed the linter issues, the test still failed, but on another assertion. I'm not familiar with the code and the failure is not particularly related to my changes. Someone please double-check before merging. /cc @bahlo
parse_test.go:497:
Error Trace: parse_test.go:497
Error: Not equal:
expected: 5
actual : 4
Test: TestParseTestSuite/TestParse
Messages: <6> Mar 7 05:45:39 eth systemd[1]: Starting Message of the Day...
The usual procedure:
I also addressed the linter issues. However, one test is failing. Not because of my change, tests were not passing for
main
, either. One interesting thing: After I addressed the linter issues, the test still failed, but on another assertion. I'm not familiar with the code and the failure is not particularly related to my changes. Someone please double-check before merging. /cc @bahloFor reference:
Before my linter fixes it was: