I think it wasn't discovered on this PR because CI is configured to only fail on "new" linter issues. And I think "new" in that context means "newly introduced code that doesn't pass linting". Sorry I can't give you a more elaborate answer at this point, need to investigate.
But the failures look rather simple. Would you mind taking a look at fixing those? Otherwise I put it on my list. make lint should be your friend :D Looks like you just need to underscore (_) some unused params.
smorimoto
commented
4 months ago
@smorimoto The bump of
golangci-lintresulted in some new linting problems discovered on themainbranch: https://github.com/axiomhq/axiom-syslog-proxy/actions/runs/8568431586.I think it wasn't discovered on this PR because CI is configured to only fail on "new" linter issues. And I think "new" in that context means "newly introduced code that doesn't pass linting". Sorry I can't give you a more elaborate answer at this point, need to investigate.
But the failures look rather simple. Would you mind taking a look at fixing those? Otherwise I put it on my list.
make lintshould be your friend :D Looks like you just need to underscore (_) some unused params.